Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly cast ENUMs to TEXT for CASE and CONVERT statements #2791

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Properly cast ENUMs to TEXT for CASE and CONVERT statements #2791

merged 5 commits into from
Dec 12, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Dec 12, 2024

max-hoffman
max-hoffman approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the expression is shaped correctly for if we want to expand the usage at some point

@jycor jycor merged commit 260b407 into main Dec 12, 2024
8 checks passed
@jycor jycor deleted the james/enum branch December 12, 2024 23:26
@BrewTestBot BrewTestBot mentioned this pull request Dec 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enum conversion type has unexpected results
2 participants
@jycor @max-hoffman