Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get field string concat #2732

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Get field string concat #2732

merged 3 commits into from
Nov 5, 2024

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Nov 4, 2024 •
edited
Loading

Replace fmt.Sprintf with string concat (+).

BenchmarkSprintf-12        	18748582	        63.29 ns/op
BenchmarkAddString-12    	39934550	        27.61 ns/op

@max-hoffman max-hoffman mentioned this pull request Nov 4, 2024
Closed
@max-hoffman max-hoffman requested a review from jycor November 4, 2024 18:42
jycor
jycor approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@max-hoffman max-hoffman changed the title Get field string append Get field string concat Nov 5, 2024
@max-hoffman max-hoffman merged commit 2bf2c60 into main Nov 5, 2024
9 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 6, 2024
Merged
@max-hoffman max-hoffman deleted the max/get-field-string-append branch November 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-hoffman @jycor