Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation/range scan perf edits #2628

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Aggregation/range scan perf edits #2628

merged 5 commits into from
Aug 13, 2024

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Aug 9, 2024

  • Resolving aggregation functions checks the integrator function provider first. The interface required us to create an expensive error object to resolve any standard functions. Now we only create the error object if a function name is not found in integrator and standard list.
  • Skip duplicate unused functional dependency tracking in coster.
  • Aggregations with no group by and single scopes can only return one row, so use the sql.QFlagMax1Row shortcut.

benchmarks here: dolthub/dolt#8241

@max-hoffman max-hoffman requested a review from zachmu August 13, 2024 17:02
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sql/analyzer/catalog.go Outdated Show resolved Hide resolved
sql/planbuilder/aggregates.go Outdated Show resolved Hide resolved
@max-hoffman max-hoffman merged commit e94bb7d into main Aug 13, 2024
6 of 8 checks passed
@max-hoffman max-hoffman deleted the max/range-group-perf branch August 13, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants