implement icu_version function
#2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-hoffman
reviewed
Aug 7, 2024
sql/expression/function/registry.go
Outdated
| @@ -102,6 +102,7 @@ var BuiltIns = []sql.Function{ | |||
| sql.Function2{Name: "gtid_subtract", Fn: NewGtidSubtract}, | |||
| sql.Function1{Name: "hex", Fn: NewHex}, | |||
| sql.Function1{Name: "hour", Fn: NewHour}, | |||
| sql.Function0{Name: "icu_version", Fn: NewICUVersion}, | |||
There was a problem hiding this comment.
do we really need the intermediaries? can we just pre-fold the constant and return a literal here?
max-hoffman
approved these changes
Aug 7, 2024
sql/planbuilder/scalar.go
Outdated
| @@ -133,6 +134,8 @@ func (b *Builder) buildScalar(inScope *scope, e ast.Expr) (ex sql.Expression) { | |||
| name := v.Name.Lowered() | |||
| if name == "name_const" { | |||
| return b.buildNameConst(inScope, v) | |||
| } else if name == "icu_version" { | |||
| return expression.NewLiteral("73.1", types.MustCreateString(query.Type_VARCHAR, 4, sql.Collation_Default)) | |||
There was a problem hiding this comment.
can we const this out somewhere? maybe with a docs reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL Docs: https://dev.mysql.com/doc/refman/8.4/en/information-functions.html#function_icu-version