Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceChecker interface #2132

Merged
merged 1 commit into from
Nov 7, 2023
Merged

ReferenceChecker interface #2132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions sql/plan/foreign_key_editor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (fkEditor *ForeignKeyEditor) OnUpdateRestrict(ctx *sql.Context, refActionDa
return nil
}

rowIter, err := refActionData.RowMapper.GetIter(ctx, old)
rowIter, err := refActionData.RowMapper.GetIter(ctx, old, false)
if err != nil {
return err
}
Expand All @@ -144,7 +144,7 @@ func (fkEditor *ForeignKeyEditor) OnUpdateCascade(ctx *sql.Context, refActionDat
return nil
}

rowIter, err := refActionData.RowMapper.GetIter(ctx, old)
rowIter, err := refActionData.RowMapper.GetIter(ctx, old, false)
if err != nil {
return err
}
Expand Down Expand Up @@ -182,7 +182,7 @@ func (fkEditor *ForeignKeyEditor) OnUpdateSetNull(ctx *sql.Context, refActionDat
return nil
}

rowIter, err := refActionData.RowMapper.GetIter(ctx, old)
rowIter, err := refActionData.RowMapper.GetIter(ctx, old, false)
if err != nil {
return err
}
Expand Down Expand Up @@ -243,7 +243,7 @@ func (fkEditor *ForeignKeyEditor) Delete(ctx *sql.Context, row sql.Row, depth in

// OnDeleteRestrict handles the ON DELETE RESTRICT referential action.
func (fkEditor *ForeignKeyEditor) OnDeleteRestrict(ctx *sql.Context, refActionData ForeignKeyRefActionData, row sql.Row) error {
rowIter, err := refActionData.RowMapper.GetIter(ctx, row)
rowIter, err := refActionData.RowMapper.GetIter(ctx, row, false)
if err != nil {
return err
}
Expand All @@ -260,7 +260,7 @@ func (fkEditor *ForeignKeyEditor) OnDeleteRestrict(ctx *sql.Context, refActionDa

// OnDeleteCascade handles the ON DELETE CASCADE referential action.
func (fkEditor *ForeignKeyEditor) OnDeleteCascade(ctx *sql.Context, refActionData ForeignKeyRefActionData, row sql.Row, depth int) error {
rowIter, err := refActionData.RowMapper.GetIter(ctx, row)
rowIter, err := refActionData.RowMapper.GetIter(ctx, row, false)
if err != nil {
return err
}
Expand Down Expand Up @@ -289,7 +289,7 @@ func (fkEditor *ForeignKeyEditor) OnDeleteCascade(ctx *sql.Context, refActionDat

// OnDeleteSetNull handles the ON DELETE SET NULL referential action.
func (fkEditor *ForeignKeyEditor) OnDeleteSetNull(ctx *sql.Context, refActionData ForeignKeyRefActionData, row sql.Row, depth int) error {
rowIter, err := refActionData.RowMapper.GetIter(ctx, row)
rowIter, err := refActionData.RowMapper.GetIter(ctx, row, false)
if err != nil {
return err
}
Expand Down Expand Up @@ -377,7 +377,7 @@ func (reference *ForeignKeyReferenceHandler) CheckReference(ctx *sql.Context, ro
}
}

rowIter, err := reference.RowMapper.GetIter(ctx, row)
rowIter, err := reference.RowMapper.GetIter(ctx, row, true)
if err != nil {
return err
}
Expand Down Expand Up @@ -458,7 +458,7 @@ func (mapper *ForeignKeyRowMapper) IsInitialized() bool {
}

// GetIter returns a row iterator for all rows that match the given source row.
func (mapper *ForeignKeyRowMapper) GetIter(ctx *sql.Context, row sql.Row) (sql.RowIter, error) {
func (mapper *ForeignKeyRowMapper) GetIter(ctx *sql.Context, row sql.Row, refCheck bool) (sql.RowIter, error) {
rang := make(sql.Range, len(mapper.IndexPositions)+len(mapper.AppendTypes))
for rangPosition, rowPos := range mapper.IndexPositions {
rowVal := row[rowPos]
Expand All @@ -480,6 +480,13 @@ func (mapper *ForeignKeyRowMapper) GetIter(ctx *sql.Context, row sql.Row) (sql.R

editorData := mapper.Updater.IndexedAccess(lookup)

if rc, ok := editorData.(sql.ReferenceChecker); refCheck && ok {
err := rc.SetReferenceCheck()
if err != nil {
return nil, err
}
}

partIter, err := editorData.LookupPartitions(ctx, lookup)
if err != nil {
return nil, err
Expand Down
8 changes: 8 additions & 0 deletions sql/tables.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,14 @@ type ForeignKeyEditor interface {
IndexAddressable
}

// ReferenceChecker is usually an IndexAddressableTable that does key
// lookups for existence checks. Indicating that the engine is performing
// a reference check lets the integrator avoid expensive deserialization
// steps.
type ReferenceChecker interface {
SetReferenceCheck() error
}

// CheckTable is a table that declares check constraints.
type CheckTable interface {
Table
Expand Down