Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return module to pool on regex.Close() #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

max-hoffman
Copy link

privateRegex.Close()'s error handling was circumventing returning the module back to the pool. I don't understand the code well enough to know whether the other error handling logic is correct, but even in the error case I imagine we want to return the module objects to the pool.

@max-hoffman max-hoffman mentioned this pull request Dec 14, 2024
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but it won’t fix the issue. Modifying the code such that there’s a single module (without the pool altogether) still has the memory leak, albeit slower. This will help my mentioned PR reclaim memory faster in the event of an error, but it doesn’t solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants