You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1206: Added loop structures and label support
This adds the rest of the "non-FOR" loops, along with loop control flow and labels. I also noticed that we weren't using OperationSizeForStatements, which will properly calculate offsets for the Goto operations, so I fixed that. Just so happened that our tests weren't running into the issue.
1199: NULL support in PL/pgSQL
We get support for NULL statements from pg_query_go since it automatically filters them out. This change adds a test of their usage.
1197: WHILE statements in PL/pgSQL
Adds basic support for WHILE statements in PL/pgSQL. No support for labels yet.
1196: Fixed CREATE FUNCTION not executing some statements
Simple bug, but was difficult to spot. Some statements work without needing to advance the returned RowIter, while others require advancing it. I changed it so that we're always advancing the iterator. I also unskipped the skipped tests, and removed the temporary one since the original now works.
1193: Added SELECT ... INTO and PERFORM, plus bugfixes
Hoped to get a few more statements in, but there's an issue where some statements that are ran from the interpreter are seemingly being discarded. It was a roadblock even for these two, hence the skipped tests. That's the next thing I'mma look into, as it's a pretty big issue (especially since there's no error, just no effect which is even worse).
1171: Bug fixes for using various types in keys
This PR allows various types to be used in keys that were not possible before. This comes down to two things:
Swap out the validateCreateTable analyzer rule
Change the determination for the max width of a type to be more accurate, which influences whether we choose standard extended encoding or extended address encoding
Alter the way we determine the encoding type for extended columns in keys to more closely match the non-key case (dolthub/dolt#8817)
This PR also has a couple small regressions in tests. I'm punting on these because we're about to completely overhaul how we store these types (to implement toast semantics).