Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for dolt_statistics #1004

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Add tests for dolt_statistics #1004

merged 2 commits into from
Nov 27, 2024

Conversation

tbantle22
Copy link
Contributor

@tbantle22 tbantle22 commented Nov 22, 2024

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Main PR
covering_index_scan_postgres 436.12/s 436.67/s +0.1%
index_join_postgres 162.05/s 160.77/s -0.8%
index_join_scan_postgres 187.19/s 186.55/s -0.4%
index_scan_postgres 15.07/s 14.98/s -0.6%
oltp_point_select 2838.94/s 2844.34/s +0.1%
oltp_read_only 1938.96/s 1912.83/s -1.4%
select_random_points 120.49/s 119.63/s -0.8%
select_random_ranges 93.22/s 92.55/s -0.8%
table_scan_postgres 14.78/s 14.72/s -0.5%
types_table_scan_postgres 6.95/s 6.92/s -0.5%

Copy link
Contributor

Main PR
Total 42090 42090
Successful 14534 14534
Failures 27556 27556
Partial Successes1 4689 4689
Main PR
Successful 34.5308% 34.5308%
Failures 65.4692% 65.4692%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbantle22 tbantle22 marked this pull request as ready for review November 27, 2024 17:30
@tbantle22 tbantle22 merged commit 8f98c06 into main Nov 27, 2024
14 checks passed
@tbantle22 tbantle22 deleted the taylor/stats branch November 27, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants