Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dolt sql to always log in as the root superuser #8746

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jan 14, 2025

From the command line, when a sql-server is not running, dolt sql implicitly uses the root account to log, but if the root account exists with a password, dolt sql will fail to log in. Since the user has access to the host and the database data directory, we should allow dolt sql to log into the SQL shell, even if the root user has a password set. This change also makes this behavior match when a sql-server is running, and we allow superuser login through the __dolt_local_user__ account (which only exists while a sql-server is running).

…eruser account, even if the root account was assigned a password
@fulghum fulghum requested a review from macneale4 January 14, 2025 21:39
@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
17c65a7 ok 5937457
version total_tests
17c65a7 5937457
correctness_percentage
100.0

@fulghum fulghum merged commit cabf880 into main Jan 14, 2025
34 of 35 checks passed
@fulghum fulghum deleted the fulghum/sql_shell_root_access branch January 14, 2025 23:53
Copy link

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 1.33
batching batch sql 10000 1 0.09 1.22
batching by line sql 10000 1 0.09 1.33
blob 1 blob 200000 1 0.9 3.81 4.49
blob 2 blobs 200000 1 0.91 4.22 4.67
blob no blob 200000 1 0.95 2.25 2.59
col type datetime 200000 1 0.87 2.25 2.47
col type varchar 200000 1 0.76 3.01 3.37
config width 2 cols 200000 1 0.8 2.4 2.7
config width 32 cols 200000 1 1.88 2.02 2.72
config width 8 cols 200000 1 1 2.27 2.62
pk type float 200000 1 0.85 2.46 2.69
pk type int 200000 1 0.9 2.14 2.34
pk type varchar 200000 1 2.81 0.9 1.07
row count 1.6mm 1600000 1 5.9 2.77 2.63
row count 400k 400000 1 1.5 2.63 2.68
row count 800k 800000 1 2.93 2.78 2.65
secondary index four index 200000 1 3.62 1.35 1.22
secondary index no secondary 200000 1 1.08 2.02 2.3
secondary index one index 200000 1 1.16 2.32 2.45
secondary index two index 200000 1 2.04 1.71 1.74
sorting shuffled 1mm 1000000 0 5.16 2.75 2.65
sorting sorted 1mm 1000000 1 5.18 2.7 2.65

Copy link

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.19
dolt_blame_commit_filter system table 3.01
dolt_commit_ancestors_commit_filter system table 0.61
dolt_commits_commit_filter system table 1.05
dolt_diff_log_join_from_commit system table 2.94
dolt_diff_log_join_to_commit system table 2.8
dolt_diff_table_from_commit_filter system table 1.18
dolt_diff_table_to_commit_filter system table 1.16
dolt_diffs_commit_filter system table 1.03
dolt_history_commit_filter system table 1.39
dolt_log_commit_filter system table 1.1

Copy link

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.14
adds_updates_deletes 60000 60000 60000 4.57
deletes_only 0 60000 0 2.45
updates_only 0 0 60000 3.08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants