Add "dolt_optimize_json" system variable. #8722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite Json documents to storage as simple blobs instead of path-indexed trees.
nicktobey
changed the title
fulghum
approved these changes
Jan 8, 2025
integration-tests/bats/json.bats
Outdated
Comment on lines
265
to
267
| # This test inserts a large JSON document with the `dolt_dont_optimize_json` flag set. | ||
| # We expect that the document gets stored as a blob. | ||
| @test "json: Test dolt_dont_optimize_json system variable" { |
There was a problem hiding this comment.
Suggested change
| # This test inserts a large JSON document with the `dolt_dont_optimize_json` flag set. | |
| # We expect that the document gets stored as a blob. | |
| @test "json: Test dolt_dont_optimize_json system variable" { | |
| # This test inserts a large JSON document with the `dolt_optimize_json` flag disabled. | |
| # We expect that the document gets stored as a blob. | |
| @test "json: Test dolt_optimize_json system variable disabled" { |
Comment on lines
313
to
317
| dontOptimizeJson, err := sqlCtx.Session.GetSessionVariable(sqlCtx, "dolt_optimize_json") | ||
| if err != nil { | ||
| return hash.Hash{}, err | ||
| } | ||
| if dontOptimizeJson == uint8(0) { |
There was a problem hiding this comment.
Suggested change
| dontOptimizeJson, err := sqlCtx.Session.GetSessionVariable(sqlCtx, "dolt_optimize_json") | |
| if err != nil { | |
| return hash.Hash{}, err | |
| } | |
| if dontOptimizeJson == uint8(0) { | |
| optimizeJson, err := sqlCtx.Session.GetSessionVariable(sqlCtx, "dolt_optimize_json") | |
| if err != nil { | |
| return hash.Hash{}, err | |
| } | |
| if optimizeJson == uint8(0) { |
|
@nicktobey DOLT
|
…timize_json" to "dolt_optimize_json"
|
@nicktobey DOLT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When set to 0, Dolt will write Json documents to storage as simple blobs instead of path-indexed trees.
This is useful as a workaround to a current issue where the JSON chunker won't chunk in the middle of large string literals, resulting in larger-than-expected chunks.