Bug fix: replication fails when a branch is deleted and tag with same name is created #8653
+45
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with the same name will have the same path
fulghum
force-pushed
the
fulghum/replica-bug-fix
branch
from
28a5510 to
cf1edd8
Compare
reltuk
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our logic to update refs in a read replica was tracking updated refs by path, so when branch
b1was deleted and tagb1was added, the code was mixing them up and trying to update the branch with the tag ref.The fix is to track replicated refs by ID, instead of by path, to avoid collisions. This also changes the first return parameter of the
pullBranchesfunction, but none of the three places that call this function assign that first return param to a variable, so that change doesn't affect anything.