Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-release-notes] skip more wire allocs #8651

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Conversation

max-hoffman
Copy link
Contributor

No description provided.

@max-hoffman
Copy link
Contributor Author

#benchmark

Copy link

github-actions bot commented Dec 6, 2024

@max-hoffman
Copy link
Contributor Author

#benchmark

Copy link

github-actions bot commented Dec 9, 2024

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 57.87 61.08 5.55
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 58d4626 40.96 dolt 2e9d2ef 40.24 -1.76

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.61 0.62 1.64
groupby_scan 16.12 16.71 3.66
index_join 2.26 2.3 1.77
index_join_scan 1.39 1.47 5.76
index_scan 50.11 43.39 -13.41
oltp_point_select 0.26 0.27 3.85
oltp_read_only 5.28 5.37 1.7
select_random_points 0.63 0.64 1.59
select_random_ranges 0.63 0.65 3.17
table_scan 50.11 43.39 -13.41
types_table_scan 137.35 114.72 -16.48
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.09 6.21 1.97
oltp_insert 3.02 3.07 1.66
oltp_read_write 11.45 11.65 1.75
oltp_update_index 3.07 3.13 1.95
oltp_update_non_index 3.02 3.02 0.0
oltp_write_only 6.09 6.21 1.97
types_delete_insert 6.43 6.55 1.87

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
133b582 ok 5937457
version total_tests
133b582 5937457
correctness_percentage
100.0

@max-hoffman
Copy link
Contributor Author

#benchmark

Copy link

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8713fec ok 5937457
version total_tests
8713fec 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 62.19 61.08 -1.78
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt ffd5bde 39.43 dolt 8713fec 39.81 0.96

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.62 0.62 0.0
groupby_scan 16.41 17.01 3.66
index_join 2.3 2.35 2.17
index_join_scan 1.42 1.47 3.52
index_scan 51.94 42.61 -17.96
oltp_point_select 0.27 0.27 0.0
oltp_read_only 5.47 5.37 -1.83
select_random_points 0.65 0.65 0.0
select_random_ranges 0.65 0.65 0.0
table_scan 51.94 43.39 -16.46
types_table_scan 139.85 112.67 -19.44
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.21 6.32 1.77
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.87 11.65 -1.85
oltp_update_index 3.13 3.13 0.0
oltp_update_non_index 3.07 3.07 0.0
oltp_write_only 6.32 6.32 0.0
types_delete_insert 6.55 6.55 0.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d115e67 ok 5937457
version total_tests
d115e67 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6ac6ed5 ok 5937457
version total_tests
6ac6ed5 5937457
correctness_percentage
100.0

@max-hoffman max-hoffman merged commit 20135d8 into main Dec 11, 2024
21 checks passed
@max-hoffman max-hoffman deleted the max/wire-alloc-bump branch December 11, 2024 03:38
nicktobey pushed a commit that referenced this pull request Dec 17, 2024
* [no-release-notes] skip more wire allocs

* bump

* bump

* bump

* bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants