Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable larger statements for dolt_procedures #8650

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Enable larger statements for dolt_procedures #8650

merged 3 commits into from
Dec 11, 2024

Conversation

macneale4
Copy link
Contributor

@macneale4 macneale4 commented Dec 6, 2024 •
edited
Loading

Increase the supported stored procedure length from 1K to 8K.

@macneale4 macneale4 requested a review from fulghum December 6, 2024 23:36
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ebf9f8b ok 5937457
version total_tests
ebf9f8b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f1c0bd3 ok 5937457
version total_tests
f1c0bd3 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
2451899 ok 5937457
version total_tests
2451899 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5fdb9bb ok 5937457
version total_tests
5fdb9bb 5937457
correctness_percentage
100.0

fulghum
fulghum approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@macneale4 macneale4 merged commit a4a6fe1 into main Dec 11, 2024
21 checks passed
@macneale4 macneale4 deleted the macneale4/long-proc branch December 11, 2024 20:23
@BrewTestBot BrewTestBot mentioned this pull request Dec 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macneale4 @coffeegoddd @fulghum