Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed persitence behavior from config #8645

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Removed persitence behavior from config #8645

merged 5 commits into from
Dec 6, 2024

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Dec 6, 2024

No description provided.

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
010c325 ok 5937457
version total_tests
010c325 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
429f839 ok 5937457
version total_tests
429f839 5937457
correctness_percentage
100.0

@zachmu zachmu requested a review from bheni December 6, 2024 21:43
@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
1a0986c ok 5937457
version total_tests
1a0986c 5937457
correctness_percentage
100.0

jycor
jycor approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmu zachmu merged commit 59314e9 into main Dec 6, 2024
21 checks passed
@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
324e4bb ok 5937457
version total_tests
324e4bb 5937457
correctness_percentage
100.0

@BrewTestBot BrewTestBot mentioned this pull request Dec 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

@bheni bheni Awaiting requested review from bheni

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachmu @coffeegoddd @jycor