Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-release-notes] bump for time bytes proto #8640

Closed
wants to merge 2 commits into from

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Dec 5, 2024

time SQL avoids string alloc and fmt.Sprintf

GMS: dolthub/go-mysql-server#2782

@max-hoffman max-hoffman changed the title bump for time bytes proto [no-release-notes] bump for time bytes proto Dec 5, 2024
@max-hoffman
Copy link
Contributor Author

#benchmark

Copy link

github-actions bot commented Dec 5, 2024

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 59.99 58.92 -1.78
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 0bd3f06 40.69 dolt f3d1a64 40.2 -1.2

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.62 0.61 -1.61
groupby_scan 16.41 16.41 0.0
index_join 2.3 2.3 0.0
index_join_scan 1.44 1.44 0.0
index_scan 55.82 51.02 -8.6
oltp_point_select 0.27 0.26 -3.7
oltp_read_only 5.47 5.28 -3.47
select_random_points 0.65 0.63 -3.08
select_random_ranges 0.65 0.63 -3.08
table_scan 56.84 51.94 -8.62
types_table_scan 147.61 139.85 -5.26
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.21 6.21 0.0
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.87 11.65 -1.85
oltp_update_index 3.13 3.13 0.0
oltp_update_non_index 3.07 3.02 -1.63
oltp_write_only 6.21 6.21 0.0
types_delete_insert 6.55 6.55 0.0

@max-hoffman
Copy link
Contributor Author

#benchmark

Copy link

github-actions bot commented Dec 6, 2024

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 61.08 58.92 -3.54
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 77c3bf6 39.81 dolt fb3e20e 40.4 1.48

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.62 0.62 0.0
groupby_scan 16.41 16.71 1.83
index_join 2.26 2.3 1.77
index_join_scan 1.47 1.47 0.0
index_scan 55.82 52.89 -5.25
oltp_point_select 0.27 0.27 0.0
oltp_read_only 5.47 5.47 0.0
select_random_points 0.65 0.65 0.0
select_random_ranges 0.65 0.65 0.0
table_scan 55.82 52.89 -5.25
types_table_scan 147.61 142.39 -3.54
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.21 6.21 0.0
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.87 11.65 -1.85
oltp_update_index 3.13 3.13 0.0
oltp_update_non_index 3.07 3.07 0.0
oltp_write_only 6.21 6.21 0.0
types_delete_insert 6.55 6.55 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants