Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema fixes for dolt_status, dolt_merge_status, and dolt_constraint_violations_* tables for doltgres #8636

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Schema fixes for dolt_status, dolt_merge_status, and dolt_constraint_violations_* tables for doltgres #8636

merged 5 commits into from
Dec 5, 2024

Conversation

tbantle22
Copy link
Contributor

No description provided.

@tbantle22 tbantle22 force-pushed the taylor/more-dg-types branch 2 times, most recently from e1573e2 to 8e728fa Compare December 4, 2024 19:51
@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8e728fa ok 5937457
version total_tests
8e728fa 5937457
correctness_percentage
100.0

@tbantle22 tbantle22 force-pushed the taylor/more-dg-types branch from 8e728fa to e10835a Compare December 4, 2024 20:39
@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e10835a ok 5937457
version total_tests
e10835a 5937457
correctness_percentage
100.0

@tbantle22 tbantle22 requested a review from zachmu December 4, 2024 21:11
zachmu
zachmu approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e11b19b ok 5937457
version total_tests
e11b19b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@tbantle22 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7411748 ok 5937457
version total_tests
7411748 5937457
correctness_percentage
100.0

@tbantle22 tbantle22 merged commit 3d7df6d into main Dec 5, 2024
21 checks passed
@tbantle22 tbantle22 deleted the taylor/more-dg-types branch December 5, 2024 18:17
@BrewTestBot BrewTestBot mentioned this pull request Dec 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbantle22 @coffeegoddd @zachmu