Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error message for duplicate unique key violation on out of band types #8632

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix error message for duplicate unique key violation on out of band types #8632

merged 2 commits into from
Dec 3, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Dec 3, 2024

Certain types are stored out of band (like TEXT and BLOB), so we compare their addresses to test for existence. Consequently, the error message would contain the hash rather than the contents.

This PR fixes the formatting to print the prefix.

fixes: #8629

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
43f57d8 ok 5937457
version total_tests
43f57d8 5937457
correctness_percentage
100.0

fulghum
fulghum approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice work making sure that error message has user content in it and not an address that users wouldn't know what to do with.

go/libraries/doltcore/sqle/writer/prolly_index_writer.go Show resolved Hide resolved
@jycor jycor changed the title deref for error fix error message for duplicate unique key violation on out of band types Dec 3, 2024
@jycor jycor merged commit 192e1c1 into main Dec 3, 2024
21 of 22 checks passed
@jycor jycor deleted the james/error branch December 3, 2024 23:12
@BrewTestBot BrewTestBot mentioned this pull request Dec 5, 2024
Merged
nicktobey pushed a commit that referenced this pull request Dec 17, 2024
@jycor @nicktobey
fix error message for duplicate unique key violation on out of band t…
123f412 
…ypes (#8632)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous output with unique constraint on TEXT or TINYTEXT
3 participants
@jycor @coffeegoddd @fulghum