Give a little more information in dolt_diff_* when there is a pk change #8631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@macneale4 DOLT
|
macneale4
force-pushed
the
macneale4/alter-pk-diff
branch
from
9e151c0 to
8722691
Compare
|
@macneale4 DOLT
|
macneale4
force-pushed
the
macneale4/alter-pk-diff
branch
from
8722691 to
3b6b97c
Compare
|
@macneale4 DOLT
|
macneale4
force-pushed
the
macneale4/alter-pk-diff
branch
from
3b6b97c to
a2bd169
Compare
|
@macneale4 DOLT
|
fulghum
reviewed
Dec 5, 2024
macneale4
force-pushed
the
macneale4/alter-pk-diff
branch
from
a2bd169 to
9419265
Compare
|
@macneale4 DOLT
|
Co-authored-by: Jason Fulghum <[email protected]>
|
@macneale4 DOLT
|
fulghum
approved these changes
Dec 17, 2024
Comment on lines
685
to
687
| // isDiffablePartition checks if the commit pair for this partition is "diffable". | ||
| // If the primary key sets changed between the two commits, it may not be | ||
| // possible to diff them. |
There was a problem hiding this comment.
Probably helpful for future code readers to explain simpleDiff and fuzzyDiff in the function docs and maybe how they are intended to be used.
|
@macneale4 DOLT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the dolt_diff_* system table a little more forgiving when schema changes occur that we can kind of map from one commit to the next. In the case of the issue, adding a primary key to a key keyless table. This doesn't work in both directions though - if you can't map the schema, we stop walking history (same as before).
Minor bump required due to behavior of the dolt_diff_* table changing are a result of this change.
Fixes: #8625