Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing for show slave status #8600

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add testing for show slave status #8600

merged 2 commits into from
Nov 26, 2024

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Nov 25, 2024

This syntax is deprecated and will be removed in future MySQL versions (SHOW REPLICA STATUS should be preferred instead). However, some tools (e.g. Dolphie, MyDumper) still rely on this deprecated syntax, so we're adding support for it to keep compatibility with those tools.

Depends on:

jycor
jycor approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e60b76b ok 5937457
version total_tests
e60b76b 5937457
correctness_percentage
100.0

@jycor jycor mentioned this pull request Nov 26, 2024
Closed
@fulghum fulghum merged commit 384a914 into main Nov 26, 2024
34 of 35 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulghum @coffeegoddd @jycor