Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace nil defaults with empty string #8595

Merged
merged 2 commits into from
Nov 25, 2024
Merged

replace nil defaults with empty string #8595

merged 2 commits into from
Nov 25, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Nov 24, 2024

Needed for dolphie.

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8bc92fb ok 5937457
version total_tests
8bc92fb 5937457
correctness_percentage
100.0

fulghum
fulghum approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jycor jycor merged commit 55589e9 into main Nov 25, 2024
55 of 57 checks passed
@jycor jycor deleted the james/nil branch November 25, 2024 20:26
@BrewTestBot BrewTestBot mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jycor @coffeegoddd @fulghum