Fix schemas and procedures system tables for doltgres #8553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbantle22 DOLT
|
tbantle22
force-pushed
the
taylor/proc-sch
branch
from
9aa50b6 to
5314c7f
Compare
tbantle22
force-pushed
the
taylor/proc-sch
branch
from
5314c7f to
92c57a7
Compare
tbantle22
force-pushed
the
taylor/proc-sch
branch
from
92c57a7 to
cf06db4
Compare
tbantle22
commented
Nov 13, 2024
Comment on lines
+2318
to
+2327
| if resolve.UseSearchPath && schemaName == "" { | ||
| root, err := db.GetRoot(ctx) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| schemaName, err = resolve.FirstExistingSchemaOnSearchPath(ctx, root) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
It's kinda gross IMO that I need to set db.schemaName to dolt above to get the dolt.schemas table, but then set it to the first existing schema here to get the view to drop. Option to suggestions
tbantle22
force-pushed
the
taylor/proc-sch
branch
from
9876c7b to
f57331c
Compare
|
@tbantle22 DOLT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GMS PR: dolthub/go-mysql-server#2747
doltschema for the schemas and procedures dolt system tablesschema_namecolumn to thedolt.schemastable for doltgresdoltschema