Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark unscoped commit index as not unique #8367

Merged
merged 9 commits into from
Sep 18, 2024
Merged

mark unscoped commit index as not unique #8367

merged 9 commits into from
Sep 18, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Sep 17, 2024

The index defined over the commit_hash column was marked as unique, when it definitely is not.
Along with fix from dolthub/go-mysql-server#2665
fixes #8365

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a5ae659 ok 5937457
version total_tests
a5ae659 5937457
correctness_percentage
100.0

max-hoffman
max-hoffman approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7f48d39 ok 5937457
version total_tests
7f48d39 5937457
correctness_percentage
100.0

@jycor jycor merged commit a8dca5b into main Sep 18, 2024
21 checks passed
@jycor jycor deleted the james/commit branch September 18, 2024 07:29
@jycor jycor mentioned this pull request Sep 18, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dolt_diff with commit_hash filter errors with result max1Row iterator returned more than one row
3 participants
@jycor @coffeegoddd @max-hoffman