go/store/nbs: Fix table_index for table files with so many chunks that certain index slice operations overflow a uint32. #8252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t certain index slice operations overflow a uint32.
macneale4
approved these changes
Aug 12, 2024
| } | ||
|
|
||
| // Write Suffixes | ||
| for i := uint32(0); i < numChunks; i++ { |
There was a problem hiding this comment.
The three 320M iteration loops raises my eyebrows. How long does this take?
There was a problem hiding this comment.
And how much memory does this use? Can this be precomputed and checked in?
There was a problem hiding this comment.
It takes a few seconds to run. I'm not sure how much memory it uses. Somewhere between 4GB and 8GB.
|
@coffeegoddd DOLT
|
|
@coffeegoddd DOLT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.