Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liuliu/color-string-fix #8251

Merged
merged 1 commit into from
Aug 12, 2024
Merged

liuliu/color-string-fix #8251

merged 1 commit into from
Aug 12, 2024

Conversation

liuliu-dev
Copy link
Contributor

No description provided.

@liuliu-dev liuliu-dev requested a review from macneale4 August 12, 2024 16:16
macneale4
macneale4 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e53c2f3 ok 5937457
version total_tests
e53c2f3 5937457
correctness_percentage
100.0

@liuliu-dev liuliu-dev merged commit a7b7fde into main Aug 12, 2024
34 of 35 checks passed
@liuliu-dev liuliu-dev deleted the liuliu/color-string-fix branch August 12, 2024 16:49
@BrewTestBot BrewTestBot mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macneale4 macneale4 macneale4 approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuliu-dev @coffeegoddd @macneale4