Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] Improve how non-leaf blob nodes are displayed in dolt show #8198

Merged
merged 1 commit into from
Aug 8, 2024
Merged

[no-release-notes] Improve how non-leaf blob nodes are displayed in dolt show #8198

merged 1 commit into from
Aug 8, 2024

Conversation

nicktobey
Copy link
Contributor

Blob non-leaf nodes do not have keys, so we shouldn't try to print them.

This also fixes an error in computing the length of the address map array in blob nodes, which was previously unused.

@nicktobey nicktobey requested a review from jycor August 2, 2024 15:48
@coffeegoddd
Copy link
Contributor

@nicktobey DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3ee1b18 ok 5937457
version total_tests
3ee1b18 5937457
correctness_percentage
100.0

jycor
jycor approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicktobey nicktobey merged commit b01a12c into main Aug 8, 2024
21 of 22 checks passed
@nicktobey nicktobey deleted the nicktobey/showfix branch August 8, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicktobey @coffeegoddd @jycor