Skip to content

Commit

Permalink
more
Browse files Browse the repository at this point in the history
  • Loading branch information
James Cor committed Jan 2, 2025
1 parent 75e7159 commit e161a3e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions go/libraries/doltcore/sqle/procedures_table_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func TestProceduresMigration(t *testing.T) {
{"proc1", "create procedure proc1() SELECT 42 as pk from dual;", timestamp, timestamp, nil},
{"proc2", "create procedure proc2() SELECT 'HELLO' as greeting from dual;", timestamp, timestamp, nil},
}
assert.Equal(t, expectedRows, rows)
assert.Equal(t, expectedRows, sql.RowsToUntyped(rows))
})

t.Run("test that fetching stored procedure triggers the migration logic", func(t *testing.T) {
Expand All @@ -77,7 +77,7 @@ func TestProceduresMigration(t *testing.T) {
{"proc1", "create procedure proc1() SELECT 42 as pk from dual;", timestamp, timestamp, nil},
{"proc2", "create procedure proc2() SELECT 'HELLO' as greeting from dual;", timestamp, timestamp, nil},
}
assert.Equal(t, expectedRows, rows)
assert.Equal(t, expectedRows, sql.RowsToUntyped(rows))
})

t.Run("test that adding a new stored procedure triggers the migration logic", func(t *testing.T) {
Expand Down Expand Up @@ -107,7 +107,7 @@ func TestProceduresMigration(t *testing.T) {
{"proc2", "create procedure proc2() SELECT 'HELLO' as greeting from dual;", timestamp, timestamp, nil},
{"proc3", "create procedure proc3() SELECT 47 as pk from dual;", timestamp, timestamp, "NO_ENGINE_SUBSTITUTION"},
}
assert.Equal(t, expectedRows, rows)
assert.Equal(t, expectedRows, sql.RowsToUntyped(rows))
})

}
Expand Down
2 changes: 1 addition & 1 deletion go/libraries/doltcore/sqle/schema_table_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ func TestAncientSchemaTableMigration(t *testing.T) {
{"view", "view1", "SELECT v1 FROM test;", nil, nil},
{"view", "view2", "SELECT v2 FROM test;", nil, nil},
}
assert.Equal(t, expectedRows, rows)
assert.Equal(t, expectedRows, sql.RowsToUntyped(rows))
}

func TestV1SchemasTable(t *testing.T) {
Expand Down

0 comments on commit e161a3e

Please sign in to comment.