go/libraries/doltcore/env: Do not copy the http.Transport value, whic…

…h is not safe.
dolthub · Nov 2, 2024 · c61adf4 · c61adf4
1 parent 8d174fa
commit c61adf4
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/go/libraries/doltcore/env/grpc_dial_provider.go b/go/libraries/doltcore/env/grpc_dial_provider.go
@@ -94,11 +94,19 @@ func (p GRPCDialProvider) GetGRPCDialParams(config grpcendpoint.Config) (dbfacto
 		tc := credentials.NewTLS(config.TLSConfig)
 		opts = append(opts, grpc.WithTransportCredentials(tc))
 
-		transport := *defaultTransport
-		transport.TLSClientConfig = config.TLSConfig
-		transport.ForceAttemptHTTP2 = true
+		transport := &http.Transport{
+			Proxy:                 http.ProxyFromEnvironment,
+			DialContext:           defaultDialer.DialContext,
+			ForceAttemptHTTP2:     true,
+			MaxIdleConns:          1024,
+			MaxIdleConnsPerHost:   256,
+			IdleConnTimeout:       90 * time.Second,
+			TLSClientConfig:       config.TLSConfig,
+			TLSHandshakeTimeout:   10 * time.Second,
+			ExpectContinueTimeout: 1 * time.Second,
+		}
 		httpfetcher = &http.Client{
-			Transport: &transport,
+			Transport: transport,
 		}
 	} else if config.Insecure {
 		opts = append(opts, grpc.WithInsecure())