[no-release-notes] tests for read-commit translation isolation level (#…

…8529)
dolthub · Nov 5, 2024 · 9ad3782 · 9ad3782
1 parent 134372c
commit 9ad3782
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/go/go.mod b/go/go.mod
@@ -57,7 +57,7 @@ require (
 	github.com/cespare/xxhash/v2 v2.2.0
 	github.com/creasty/defaults v1.6.0
 	github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2
-	github.com/dolthub/go-mysql-server v0.18.2-0.20241104142123-e00c563047c0
+	github.com/dolthub/go-mysql-server v0.18.2-0.20241105220811-e48937b9c7a2
 	github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63
 	github.com/dolthub/swiss v0.1.0
 	github.com/goccy/go-json v0.10.2

diff --git a/go/go.sum b/go/go.sum
@@ -183,8 +183,8 @@ github.com/dolthub/fslock v0.0.3 h1:iLMpUIvJKMKm92+N1fmHVdxJP5NdyDK5bK7z7Ba2s2U=
 github.com/dolthub/fslock v0.0.3/go.mod h1:QWql+P17oAAMLnL4HGB5tiovtDuAjdDTPbuqx7bYfa0=
 github.com/dolthub/go-icu-regex v0.0.0-20240916130659-0118adc6b662 h1:aC17hZD6iwzBwwfO5M+3oBT5E5gGRiQPdn+vzpDXqIA=
 github.com/dolthub/go-icu-regex v0.0.0-20240916130659-0118adc6b662/go.mod h1:KPUcpx070QOfJK1gNe0zx4pA5sicIK1GMikIGLKC168=
-github.com/dolthub/go-mysql-server v0.18.2-0.20241104142123-e00c563047c0 h1:89pFCcn78El3hYvNK11Vx9ez2bQAGSrMu6CLFO0BdXQ=
-github.com/dolthub/go-mysql-server v0.18.2-0.20241104142123-e00c563047c0/go.mod h1:0xWs/FBE4xlhlOsAWoGh24SDRHemT7/U1nApu7SNRXg=
+github.com/dolthub/go-mysql-server v0.18.2-0.20241105220811-e48937b9c7a2 h1:m/LVJjR7wpS3i2QroURpNoQkSu4GaUyjSwiVW09dcf0=
+github.com/dolthub/go-mysql-server v0.18.2-0.20241105220811-e48937b9c7a2/go.mod h1:0xWs/FBE4xlhlOsAWoGh24SDRHemT7/U1nApu7SNRXg=
 github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63 h1:OAsXLAPL4du6tfbBgK0xXHZkOlos63RdKYS3Sgw/dfI=
 github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63/go.mod h1:lV7lUeuDhH5thVGDCKXbatwKy2KW80L4rMT46n+Y2/Q=
 github.com/dolthub/ishell v0.0.0-20240701202509-2b217167d718 h1:lT7hE5k+0nkBdj/1UOSFwjWpNxf+LCApbRHgnCA17XE=

diff --git a/go/libraries/doltcore/sqle/enginetest/dolt_transaction_queries.go b/go/libraries/doltcore/sqle/enginetest/dolt_transaction_queries.go
@@ -813,6 +813,32 @@ var DoltTransactionTests = []queries.TransactionTest{
 			},
 		},
 	},
+	{
+		Name:        "TRANSACTION ISOLATION READ-COMMITTED does not break AUTOCOMMIT=OFF",
+		SetUpScript: []string{},
+		Assertions: []queries.ScriptTestAssertion{
+			{
+				Query:            "/* client a */ set session transaction isolation level read committed",
+				SkipResultsCheck: true,
+			},
+			{
+				Query:            "/* client a */ set autocommit = off",
+				SkipResultsCheck: true,
+			},
+			{
+				Query:    "/* client a */ select @@transaction_isolation, @@autocommit",
+				Expected: []sql.Row{{"READ-COMMITTED", 0}},
+			},
+			{
+				Query:            "/* client a */ savepoint abc",
+				SkipResultsCheck: true,
+			},
+			{
+				Query:    "/* client a */ release savepoint abc",
+				Expected: []sql.Row{},
+			},
+		},
+	},
 }
 
 var DoltConflictHandlingTests = []queries.TransactionTest{