Hackfix for clipping in Gormiti #9914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pokechu22
changed the title
|
Wouldn't it be better to patch the game to remove the rectangle? |
|
That would probably be better than the current fix (given the side effects of breaking a bunch of games), but if a more accurate fix is found that'd be preferable to a game patch. However, I don't own Gormiti, so I can't do a patch myself. |
Pokechu22
force-pushed
the
gormiti-clipping-hack
branch
from
914297b to
b2ec900
Compare
|
What would be the motivation of the devs to implement anti-emulation? Certainly it would be different than anti-piracy, right? |
Pokechu22
force-pushed
the
gormiti-clipping-hack
branch
from
b2ec900 to
679cab6
Compare
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
|
Closing this as this is not the correct fix (and breaks other games). I will probably investigate this further later on and come up with a better fix (once I understand the problem better). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix bug 12436.
I don't really know what I'm doing here, to be honest; I don't fully understand the clipping code.
What I do know is that the game deliberately draws a black rectangle over the entire screen (the first 3 values are the x/y/z coordinates, with the hex values first and then the decoded float values in parentheses, and the last value is the color, where alpha is 1):
It also configures the alpha test and z-test to pass for these. I can only assume that this is deliberate anti-emulation code, because there doesn't seem to be any other purpose to this rectangle.
Testing using the hardware fifoplayer showed that this rectangle did not render; I assume this is because it is passing the far plane (but I'm not 100% sure whether it's the far or near plane, as I don't have a perfect understanding of this part of rendering. The z coordinate is transformed to -1 and then projected position's z-coordinate is 0, so I think it it's the far plane, though.) My guess is that this is supposed to be a
>= 0comparison for clipping instead of a> 0comparison, which I did with the software renderer, but I did some hacky stuff in the hardware renderers instead.This PR also applies the sonic epsilon hack for
host_config.backend_depth_clamp = falseto UberShaders (it was implemented for specialized shaders in #9591). I haven't tested anything forbackend_depth_clamp = false.