Core/DSP: Fix improper uses of offsetof #9498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the C standard, an offsetof expression must evaluate to an address constant, otherwise it's undefined behavior. Fixes https://bugs.dolphin-emu.org/issues/12409 See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95942 There are still improper uses of offsetof (mostly in JitArm64) but fixing that will take more effort since there's a PPCSTATE_OFF wrapper macro that is sometimes used with non-array members and sometimes used with arrays and variable indices... Let's keep that for another PR.
|
Thanks for the quick fix. I just did a build test on my Fedora 34 machine and it looks great! I haven't done tests running anything, but it compiles fine. |
|
FYI, I followed up with a build log of the issue with PPC if that helps. I realize you already said to keep this for another PR. |
iwubcode
approved these changes
Feb 12, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the C standard, an offsetof expression must evaluate to an
address constant, otherwise it's undefined behavior.
Fixes https://bugs.dolphin-emu.org/issues/12409
See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95942
There are still improper uses of offsetof (mostly in JitArm64) but
fixing that will take more effort since there's a PPCSTATE_OFF wrapper
macro that is sometimes used with non-array members and sometimes used
with arrays and variable indices... Let's keep that for another PR.