De-memsetify Wii_SSL and fix segfault. #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dolphin-emu#7917 The first memset was clearing the delicate bits of the std::string in the struct, causing segfaults. I also removed the rest of the memsets because they were paranoid, unneeded and waseful. We shouldn't be managing the ssl libraries structs for it. I checked and the ssl library's functions were already memsetting those structs as needed.
| @@ -15,7 +15,7 @@ CWII_IPC_HLE_Device_net_ssl::CWII_IPC_HLE_Device_net_ssl(u32 _DeviceID, const st | |||
| { | |||
| for (WII_SSL& ssl : _SSL) | |||
| { | |||
| memset(&ssl, 0, sizeof(WII_SSL)); | |||
| ssl.active = false; | |||
| } | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM |
|
This fixes a crash when games attempt to connect online for me. |
|
This is not the full fix needed, that will come later. This fixes the issue at hand though. |
Parlane
added a commit
that referenced
this pull request
Dec 20, 2014
De-memsetify Wii_SSL and fix segfault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7917
The first memset was clearing the delicate bits of the std::string in the struct, causing segfaults.
I also removed the rest of the memsets because they were paranoid, unneeded and wasteful. We shouldn't be managing the ssl libraries structs for it.
I checked and the ssl library's functions were already memsetting those structs as needed.