Refactor: Infinite loop in AsyncShaderCompiler according to style guidelines

[hoogmin]

A simple refactor of an infinite loop in accordance with Dolphin's style guidelines. As of now, this appears to be the last one in the source. At least according to VSCode's file search functionality.

[Dentomologist]

What if instead we make the loop not-infinite by changing it to while(Core::GetState(Core::System::GetInstance()) != Core::State::Stopping), returning false at the bottom, and replacing the break with return true?

[hoogmin]

What if instead we make the loop not-infinite by changing it to while(Core::GetState(Core::System::GetInstance()) != Core::State::Stopping), returning false at the bottom, and replacing the break with return true?

I have just made this change. I tested it with Dolphin in its Release configuration. The shader compilation process seemed to work fine. I think it is a good suggestion considering it is the same logic but re-arranged to not be infinite. But if you see any issues, let me know and I will revert them. It's a simple change but I am being cautious to not break anything unintentionally in Dolphin.

[jordan-woyak]

LGTM. Untested.

[JosJuice]

LGTM if the two commits are squashed into one.

[dreamsyntax]

@hoogmin bump
You can use your GUI tool or git rebase -i
To squash the two commits into one commit.

[hoogmin]

@hoogmin bump You can use your GUI tool or git rebase -i To squash the two commits into one commit.

I have just done this. Thanks for telling me. I wasn't sure if the git squashing was something I had to do or a maintainer.