Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AppStream hardware mapping to metainfo XML. #13308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petterreinholdtsen
Copy link

This allow programs like isenkram to propose this package when the relevant hardware is present.

@petterreinholdtsen
Copy link
Author

As the AppStream metainfo XML file is useful also outside Flatpak, it might be a good idea to move it into a more central location in the source tree.

@BhaaLseN
Copy link
Member

Do you think it makes sense to add a comment in there, explaining that those are the Wiimote VID/PID pairs for the two Wiimote revisions? The numbers seemed familiar enough to me, but I wonder if putting a tiny bit of documentation next to them adds value for others.

@petterreinholdtsen
Copy link
Author

petterreinholdtsen commented Jan 25, 2025 via email

@BhaaLseN
Copy link
Member

Nah, it's your PR, and you probably have a good idea of what this does. All I could add is probably something like

+    <!-- Dolphin natively supports the two Wiimote revisions 057E:0306 and 057E:0330 -->
     <modalias>usb:v057Ep0306d*</modalias>
     <modalias>usb:v057Ep0330d*</modalias>

...but is this enough info for the reader? I know a thing or two about XML, but not a whole lot about AppStream.

This allow programs like isenkram to propose this package when the
relevant hardware is present.
@petterreinholdtsen
Copy link
Author

petterreinholdtsen commented Jan 25, 2025 via email

@AdmiralCurtiss
Copy link
Contributor

@OatmealDome Does this make sense to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants