Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gecko: Shadow the Hedgehog: Reloaded RA Approved Codes #13249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dreamsyntax
Copy link
Member

@dreamsyntax dreamsyntax commented Dec 28, 2024

Predecessor PR to #13204
Adds GUPR8P's required RA codes (from the community list) to Sys, in preparation for being added to the allowlist.

@dreamsyntax
Copy link
Member Author

dreamsyntax commented Dec 28, 2024

Note: Not a blocker for this PR, but something I'll want to open separately.

Hmm, we may need a deduplicate matcher if a Sys and User GameSettings file have 1:1 codes.
image

For example, if I have sys and user inis with the No Idle code, the state can be enabled from either code.
The state can only be disabled if both are disabled.
Video showcasing this behavior.
https://youtu.be/8mUQihQ0qJc

@LillyJadeKatrin
Copy link
Contributor

@LillyJadeKatrin I assume there's also something server side that needs to be done, so pinging you.

Nothing server side, it just needs to be added to the approved list and then the hash updated in AchievementManager.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants