Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove boolean flags audio common #13230

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove boolean flags audio common #13230

wants to merge 3 commits into from

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Dec 22, 2024

I was going to use Enable/Disable instead of Start/Stop, but I followed the word choice in the error messages instad.

@JosJuice
Copy link
Member

Why is this better?

@tygyh
Copy link
Contributor Author

tygyh commented Dec 23, 2024

Why is this better?

You were sceptical to this kind of change last time too.

As an example, I think StartSoundStream(system); is clearer than SetSoundStreamRunning(system, true); and these follow Martin Fowler's ideas about Flag Arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tygyh @JosJuice