curl: Update to 8.11.1 and use CMake to configure #13228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OatmealDome
force-pushed
the
fix-curl-2
branch
from
3fb75e2 to
e72ff17
Compare
|
Can't say I'm the best person for reviewing CMake subtleties, but this looks reasonable overall, including from an Android perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use a single pre-configured header for libcurl on every platform that we use Externals curl for (minus the Windows vcxproj). Needless to say, this is a bad idea.
With this PR, we now configure curl for the target platform when using CMake.
I did have to add a hack to allow libcurl to link with our Externals mbedtls when it's being used. Not sure if there's a better way to accomplish this. I also tested this PR with Windows + CMake and everything works fine there.
Fixes https://bugs.dolphin-emu.org/issues/11772.