Workaround FreeBSD/clang/fmt bug #10973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be a re-appearance of fmtlib/fmt#2455.
Except instead of being on AppleClang and MacOS, it's now on regular Clang and FreeBSD. Probably because the bug needs both clang13 and (some version of) llvm's libc++.
Our experiments showed that updating to Clang14 from ports appeared to fix it, but we would prefer to work with the stock freebsd 13.1. So, I've added a workaround to disable consteval on BSD with clang 13.
This is the same workaround that libfmt are already doing, except they detect AppleClang