-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves the demo app inside the tests/dummy #74
Conversation
Thank you! |
@briangonzalez I will also come up with another PR adding |
@gowthamrm This looks to have 404'ing assets. https://dollarshaveclub.github.io/ember-router-scroll/ Mind taking a look? |
@briangonzalez Fixed it in #76 |
Boom! Thanks. You work for Zoho!? Can you please bring back free email hosting? Pretty please. |
@gowthamrm Still no dice. I don't think you configured |
@briangonzalez I have replaced the usage of I tried production build in my development, it worked well. Can you check if the ember production build is executed when deploy script is initiated? And for time being, update the assets url in index.html in gh-pages branch with /ember-router-scroll/assets/dummy.css instead of /assets/dummy.css. This will fix the issue for now. |
@gowthamrm I've gone ahead and made you a collaborator on the project. |
Mind pushing a fix? Thanks dude! |
@briangonzalez Yea Sure. But I am unable to push in to this repo. Getting permission denied error. |
Try now, thanks. |
@briangonzalez Still no luck, unable to push. |
@briangonzalez Have pushed the changes in the gh-pages branch. https://dollarshaveclub.github.io/ember-router-scroll/ is accessible now. |
Thanks dude! |
Fixes #27
Moved the demo app from external repo in to
tests/dummy
.Removed the usage of
normalize.css
in the dummy app.