Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves the demo app inside the tests/dummy #74

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

gowthamrm
Copy link
Contributor

Fixes #27

  • Moved the demo app from external repo in to tests/dummy.

  • Removed the usage of normalize.css in the dummy app.

@briangonzalez
Copy link
Contributor

Thank you!

@briangonzalez briangonzalez merged commit fe9ca60 into DockYard:master Oct 12, 2017
@gowthamrm gowthamrm deleted the demo_app branch October 12, 2017 17:00
@gowthamrm
Copy link
Contributor Author

@briangonzalez I will also come up with another PR adding [ember-cli-github-pages](https://github.com/poetic/ember-cli-github-pages) addon to publish the demo as a github page from this project itself.

@briangonzalez
Copy link
Contributor

@gowthamrm This looks to have 404'ing assets.

https://dollarshaveclub.github.io/ember-router-scroll/

Mind taking a look?

@gowthamrm
Copy link
Contributor Author

@briangonzalez Fixed it in #76

@briangonzalez
Copy link
Contributor

Boom! Thanks.

You work for Zoho!? Can you please bring back free email hosting? Pretty please.

@briangonzalez
Copy link
Contributor

@gowthamrm Still no dice. I don't think you configured baseURL anywhere.

@gowthamrm
Copy link
Contributor Author

@briangonzalez I have replaced the usage of baseUrl with rootUrl.

I tried production build in my development, it worked well.

Can you check if the ember production build is executed when deploy script is initiated?

And for time being, update the assets url in index.html in gh-pages branch with /ember-router-scroll/assets/dummy.css instead of /assets/dummy.css. This will fix the issue for now.

@briangonzalez
Copy link
Contributor

@gowthamrm I've gone ahead and made you a collaborator on the project.

@briangonzalez
Copy link
Contributor

Mind pushing a fix? Thanks dude!

@gowthamrm
Copy link
Contributor Author

@briangonzalez Yea Sure. But I am unable to push in to this repo. Getting permission denied error.

@briangonzalez
Copy link
Contributor

Try now, thanks.

@gowthamrm
Copy link
Contributor Author

@briangonzalez Still no luck, unable to push.

@gowthamrm
Copy link
Contributor Author

@briangonzalez Have pushed the changes in the gh-pages branch.

https://dollarshaveclub.github.io/ember-router-scroll/ is accessible now.

@briangonzalez
Copy link
Contributor

Thanks dude!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants