Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the demo app with the rootUrl #76

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Updates the demo app with the rootUrl #76

merged 1 commit into from
Oct 12, 2017

Conversation

gowthamrm
Copy link
Contributor

  • Fixes the issue in loading assets for demo app in the production environment

@gowthamrm gowthamrm mentioned this pull request Oct 12, 2017
Merged
@briangonzalez briangonzalez merged commit 5379039 into DockYard:master Oct 12, 2017
@gowthamrm gowthamrm deleted the bugfix_demo branch October 12, 2017 18:38
@gowthamrm
Copy link
Contributor Author

@briangonzalez I think the issue still exists.

Can you check, if the ember production build is executed when deploy script is initiated?

And for time being, update the assets url in index.html in gh-pages branch with /ember-router-scroll/assets/dummy.css instead of /assets/dummy.css. This will fix the issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briangonzalez briangonzalez briangonzalez approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gowthamrm @briangonzalez @Turbo87 @gowtham-mk-2280