configurable scroll element #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briangonzalez
suggested changes
Aug 7, 2017
README.md
Outdated
| @@ -10,6 +10,15 @@ | |||
| ember install ember-router-scroll | |||
| ``` | |||
|
|
|||
| ### Options | |||
| You can specify the id of an element for which the scroll position is saved and set. Default is `window` for using the scroll position of the whole viewport. You can pass an options object in your applications `config/environment.js` file. | |||
There was a problem hiding this comment.
application's
config/environment.js
There was a problem hiding this comment.
@ktrhn can you put in an apostrophe in the word "application"?
There was a problem hiding this comment.
I have in the last commit: 370bb90#diff-04c6e90faac2675aa89e2176d2eec7d8
briangonzalez
suggested changes
Aug 7, 2017
addon/index.js
Outdated
| window.scrollTo(scrollPosition.x, scrollPosition.y); | ||
| if ('window' === scrollElement) { | ||
| window.scrollTo(scrollPosition.x, scrollPosition.y); | ||
|
|
briangonzalez
suggested changes
Aug 7, 2017
addon/services/router-scroll.js
Outdated
| if ('window' === scrollElement) { | ||
| x = window.scrollX; | ||
| y = window.scrollY; | ||
|
|
briangonzalez
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the scrolled element configurable. Should propably solve #56