Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if a nested route is within a fixed height container, the reset scroll doesn't work. #56

Closed
NullVoxPopuli opened this issue Jul 12, 2017 · 3 comments

Comments

@NullVoxPopuli
Copy link

NullVoxPopuli commented Jul 12, 2017

The scenario is if you have a sticky header and sticky footer.

My main div that all my routes are rendered in has these styles:

// sticky-footer styles
.inner-wrap {
  height: 100%;
  height: 100vh; // this and the overflow causes the app scroll to be in a nested scrollbar.
  overflow-x: hidden;
  background: white;
  min-height: 100%;
  display: flex;
  flex-direction: column;

  section.main-section, .shell, .inner-shell {
    flex: 1;
    // my app pretty much lives here
  }

  .sticky-footer {
    margin-top: 40px;
  }
}

So, I guess is there a way to specify what dom element has its scroll reset? maybe an array of selectors to specify?

@briangonzalez
Copy link
Contributor

@NullVoxPopuli Are you able to make a demo app? BTW, this addon only tries to manage the window scroll, but not inner element scrolling.

@NullVoxPopuli
Copy link
Author

I don't have time at the moment, but if there is a twiddle with this addon, I could modify it

@NullVoxPopuli
Copy link
Author

it works! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants