Align with Ember's HistoryLocation router #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcardarella These look like real failures now. |
|
@bcardarella Ok, there was an actual bug in 1.13 which I had to modify a test to fix. |
bcardarella
reviewed
Jan 24, 2017
| const key = get(this, 'key') || '-1'; | ||
| set(this, 'key', stateUuid); | ||
| let key = getWithDefault(this, 'key', '-1'); | ||
| console.log(key); |
bcardarella
reviewed
Jan 24, 2017
| @@ -3,7 +3,7 @@ import { moduleFor, test } from 'ember-qunit'; | |||
|
|
|||
| const { | |||
| get, | |||
| set | |||
| set, | |||
There was a problem hiding this comment.
did you intend to leave the trailing comma?
There was a problem hiding this comment.
Yeah, our lint rules enforce it.
briangonzalez
force-pushed
the
features/bc/align-with-ember-history-location
branch
from
0b4a460 to
b5aa167
Compare
bcardarella
reviewed
Jan 24, 2017
| @@ -1,25 +1,27 @@ | |||
| import Ember from 'ember'; | |||
|
|
|||
| const uuid = () => { | |||
| 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, (c) => { | |||
There was a problem hiding this comment.
this implementation of the uuid function doesn't work. It needs to return the result of this replace function. Otherwise it will always be undefined and the scrollMap will not be populated
There was a problem hiding this comment.
linting snafoo, i'll fix.
briangonzalez
force-pushed
the
features/bc/align-with-ember-history-location
branch
from
8cf1202 to
605d9ea
Compare
briangonzalez
deleted the
features/bc/align-with-ember-history-location
branch
dmuneras
pushed a commit
to dmuneras/ember-router-scroll
that referenced
this pull request
Mar 27, 2017
Link repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that emberjs/ember.js#14011 has landed
it would be best to align this library with the new implementation in
anticipation of deprecating the RouterScroll for Ember 2.13 and
eventually removing it in Ember 3.0.