Align with Ember's HistoryLocation router #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that emberjs/ember.js#14011 has landed it would be best to align this library with the new implementation in anticipation of deprecating the RouterScroll for Ember 2.13 and eventually removing it in Ember 3.0.
|
@bcardarella Thanks, we'll take a look! |
|
FWIW, I believe that https://github.com/dollarshaveclub/ember-router-scroll/blob/master/package.json#L12 is causing the test failures. It attempts to run |
|
You might be right, I'll take a look at that. |
|
Closing in favor of #40 |
|
Great! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that emberjs/ember.js#14011 has landed
it would be best to align this library with the new implementation in
anticipation of deprecating the RouterScrollRouter for Ember 2.13 and
eventually removing it in Ember 3.0.