-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting error "Cannot read property 'afterContentPaint' of null" when running tests #72
Comments
@cclo7 Any ideas? |
I am using headless Chrome to run my tests with this module.exports = {
test_page: 'tests/index.html?hidepassed',
disable_watching: true,
launch_in_ci: [
'Chrome'
],
launch_in_dev: [
],
browser_args: {
Chrome: [
'--disable-gpu',
'--headless',
'--remote-debugging-port=9222',
'--window-size=1440,900'
]
}
}; |
@nrcjbarry what type of tests are you running when encountering this error? Acceptance, integration, or unit test? |
@cclo7 I have only seen it happen in acceptance tests. |
I too am getting this during (some) acceptance tests |
@sreedhar7 any ideas? |
I encountered the same issue after an upgrade to Ember.js 2.15. I dug a bit deeper into it and I may have found out the cause. I don't think the error is in I provide more explanation here: ember-app-scheduler/ember-app-scheduler#11. |
Nevermind, I got it wrong... I figured out later that this addon uses an old version of |
I'm still getting this error in my application's acceptance tests. Wondering if 0.2.0 fixed it for everyone else? |
@ryanto do you mean 0.4.0? That is the latest release. |
@ryanto it was fixed for me for months up until I upgraded to Ember 3.0 last week. I started seeing this error again only on one test (the same test) every time. I fixed it by deleting my |
I'm running master, but this could be something I'm doing in my app. Just wanted to ask. |
I haven't seen this error in a month or so (which before saw quite often in our CI build...on |
I'm still seeing this error as well, fairly sporadically in acceptance tests. Using ember-router-scroll 0.5.0 and ember-app-scheduler 0.2.1. Still looking into why, but I'm curious if anyone else is still getting it, or has a suggestion for a fix. |
@bantic I think it is 👇. It's close to being done...made a PR to get the tests passing and have been awaiting feedback. Maybe I should push to his master instead 🤔 |
This fixes a known issue where you can get random failing tests. See DockYard/ember-router-scroll#72
This fixes a known issue where you can get randomly failing tests. See DockYard/ember-router-scroll#72
This fixes a known issue where you can get randomly failing tests. See DockYard/ember-router-scroll#72
This fixes a known issue where you can get randomly failing tests. See DockYard/ember-router-scroll#72
Still seeing this. From following development on ember-app-scheduler it looks like this PR could maybe be a fix. Update: Unfortunately that PR does not fix it. |
I believe we're still seeing this, and the root cause is the issue in ember-app-scheduler. If it's still an issue (and wasn't fixed by #73), could we have this issue re-opened to make the communication & updates easier to follow? |
@samselikoff @ryanto What version are you guys on? Still master? I perhaps would have thought the PR to make app-scheduler optional would have fixed it. I would imagine your code is never calling https://github.com/dollarshaveclub/ember-router-scroll/blob/master/addon/index.js#L32 |
Ah thanks for pointing that out! I didn't realize this was an option... Let me give it a try. |
@snewcomer/@ryanto heads up the issue actually seems to lie in the I have made a PR ember-app-scheduler/ember-app-scheduler#45 to address this and check for service lifecycles. |
I'm not sure how |
Occasionally on our build server, I get a failing test with the following error:
Cannot read property 'afterContentPaint' of null
There are only 2 hits on Google for
afterContentPaint
, and one of them is this issue: ember-app-scheduler/ember-app-scheduler#9This addon seems to be the only thing using that library. Have you ran into this error while using
ember-router-scroll
?The text was updated successfully, but these errors were encountered: