add link to ship page (#19)

[jan-krueger]

Hey :),
as requested in issue #19 I have added button to link to their ship detail page. It looks like this at the moment:

This was just an idea, and it might be better to add the link to the title and image, or somewhere else. I also added a script that can automatically generate the src/web_resources/HangarXPLOR.Ships.js file. In the script you can define this array to determine what fields you want to extract:

const fields = {
    'name': 'name',
    'url': 'url',
    'thumbnail': 'media.0.images.heap_infobox'
};

The script can be executed by simply calling npm run generate-ships-file

[Da-Geek]

This looks like it could be very useful.
Maybe link to something a little more useful like fleetyards.net pages rather than the RSI Page?

[jan-krueger]

@Da-Geek I think this is a really good idea. I have added it now. - There is a handful of ship variations (18 to be exact) that are just some special variety of another ship like "Caterpillar Pirate Edition" and they don't have a direct match on Shipyard. It shouldn't be too difficult to make educated guesses in the code as to which ship page it should link but I just haven't gotten around to implementing this yet. I will probably do this tomorrow. As far as everything else is concerned, everything seems to be working we might just wanna pick a more suitable icon.

[peter-dolkens]

Sorry, have been busy this weekend but I'll try and review more this week.

One thing I'll say, the original PR was ok, but HangarXPLOR won't ever include any direct links to third parties - not a battle I want to fight RE: privacy/security concerns - can already get tricky at times without any references to third parties or passwords.

I'd actually intended to support some third party integrations by setting up a settings page that would let you paste in third-party URLs that you wish to integrate with - but it would always be up to the user to paste those links in the first time.

I'd been meaning to add support for exporting your fleet list to https://www.starship42.com/fleetview/ in this settings area, but there's no reason we couldn't also have options for third party "wiki" links in there too.

[jan-krueger]

Fair enough. I can see how that could lead to issues. I have reverted the changes now.

[peter-dolkens]

I like this idea, but I'll have to double check the sort works as required.

The actual order of the items in the list is important - you generally need variants to appear BEFORE the base versions so that the replacement logic works.

[peter-dolkens]

e.g. Notice here that the 600i is the LAST item in the list, whilst the others are alphabetical

[peter-dolkens]

And another Example

[peter-dolkens]

And an even better example where there isn't just the base "Avenger", but also "Avenger Titan" is different to "Avenger Titan Renegade"

[peter-dolkens]

Constellation in with special ordering

[peter-dolkens]

Sorry, I forgot to hit "start review" on the comments above.

I always forget you can't see them until I start the review :\

I've also started work on the "settings" pane - you'll see it actually has something in it in the release I'm about to do!

Hoping to add more in there soon, which can then be hooked and used for third party links.

[peter-dolkens]

I've taken a few ideas from this PR and am in the process of working them into a heavily rewritten version of HangarXPLOR

https://github.com/dolkensp/HangarXPLOR/compare/v2

I'm actually loading the ship matrix dynamically now, altering and injecting records as required, then sorting it in the required ordering.

This means I'll have access to lots more functionality going forwards.

All part of an effort to make HangarXPLOR a bit more resilient to changes to support some upcoming collaboration work.