Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeDiscoverer optimalization: cache Find(Type type) requests. #426

Closed
bnordli opened this issue Oct 8, 2013 · 1 comment
Closed

TypeDiscoverer optimalization: cache Find(Type type) requests. #426

bnordli opened this issue Oct 8, 2013 · 1 comment

Comments

@bnordli
Copy link
Contributor

bnordli commented Oct 8, 2013

Each Find(Type type) requests issues a flurry of Reflection calls. As long as the list of types is known at initialization of TypeDiscoverer, the results of this method should be cached.

In a typical ProCoSys page request, such cache reduces the inclusive samples for this method from 42% to nearly nothing.
@einari
Copy link
Contributor

einari commented Oct 8, 2013

Note to self: Look at flowdock for the actual GIT DIFF that represents the change!
https://www.flowdock.com/app/dolittle/bifrost/inbox/124003

einari added a commit that referenced this issue Oct 10, 2013
@einari
Applying path from #426 - thanks to @bnordli for the optimization, it…
1c50d72 
… is in fact very noticable during startup!
@einari einari closed this as completed Oct 10, 2013
@einari einari mentioned this issue Oct 10, 2013
Closed
@bnordli bnordli mentioned this issue Jun 18, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@einari @bnordli