Use safe area guides for text label and shutter button #69
Conversation
|
@dokun1, happy that you like the small contribution. I have attached two screenshots in portrait and landscape but also the same images as photos from my iPad looking at my iPhone X (as the notch and edges are removed in screenshots). Hope this helps. I might to also have a look at the camera switch button that can be a little too close to the rounded corner. Screenshot portrait: |
|
@gerriet Before I merge, how would you feel about adding some logic to have the text area span the entire width if it gets moved down for the notch? It looks like it would fit... Let me know your thoughts! |
| if #available(iOS 11, *) { | ||
| minY = self.safeAreaLayoutGuide.layoutFrame.minY | ||
| } | ||
| minY += 5.0 |
There was a problem hiding this comment.
Right here, we could perhaps put a check to see how much minY has changed, and update self.frame.size based on this value. I would love to do this, but not having an iPhone X means I dont know what value to expect ¯_(ツ)_/¯
|
The label will be moved down 39 points. Although full width for the label would be nice on this slim and high device, I am not sure about it, because I think the camera switch button will have to be moved out of the corner slightly, which will put text and button very close to each other. Will try it out tomorrow. |
Moved a little layout logic to the proper place
|
I implemented the change you suggested and think that the distance right now is large enough and also that it really helps to have more width for the label. See also attached screenshot (iPhone X in portrait is the only case where this change is effective). I also moved some of the stuff I did from LuminaTextPromptView to LuminaViewController::updateButtonFrames(), where I think it fits better. |
|
LGTM - anything else to change before merging? |
|
I'd say "let's go" |
|
Thank you @gerriet for contributing 👍 |
To improve the layout especially on iPhoneX, the safe area guides are used for