No more availability checks #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| switch self.torchState { | ||
| //swiftlint:disable empty_enum_arguments | ||
| case .on(_): |
There was a problem hiding this comment.
Arguments can be omitted when matching enums with associated values if they are not used.empty_enum_arguments CameraActionsExtension.swift:27 |
| @@ -77,7 +77,6 @@ extension LuminaViewController { | |||
| LuminaLogger.notice(message: "torch mode should be set to on") | |||
| camera.torchState = .on(intensity: 1.0) | |||
| self.torchButton.updateTorchIcon(to: SystemButtonType.FlashState.on) | |||
| //swiftlint:disable empty_enum_arguments | |||
| case .on(_): | |||
There was a problem hiding this comment.
Arguments can be omitted when matching enums with associated values if they are not used.empty_enum_arguments ViewControllerButtonFunctions.swift:80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lumina used to check whether iOS 11 was available - mostly to see whether CoreML was possible.
Description
As of 1.6.0, Lumina requires iOS 13 as the minimum. No APIs in Lumina currently need anything higher than 13.0. Thus, this change is cosmetic in nature, and the API should be intact. There should be zero
@available()checks in Lumina nowMotivation and Context
I eventually plan to contribute some Combine subscriptions, but also some contour checking.
How Has This Been Tested?
All existing functionality tested in sample app.
Screenshots (if appropriate):
Types of changes
Checklist: