Increase speed of performing plugn trigger #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously used it but didn't have that as the version committed.
…lly in use This provides a 10x improvement for the Dokku codebase by avoiding unnecessary configuration imports.
The newer version ignores SIGURG, which was introduced in Golang 1.14. This allows us to use a newer version of Golang safely on all platforms. See golang/go#37942 for more details.
|
This has been confirmed working on arm servers, so I'm going to merge it. Huzzah! |
josegonzalez
changed the title
josegonzalez
added a commit
that referenced
this pull request
May 15, 2022
### Changed - @josegonzalez Increase speed of performing plugn trigger #86
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trigger command was importing plugin config for every plugin within it's loop. For the Dokku codebase, this caused a 10x decrease in performance due to the number of plugins, making it prohibitively expensive to perform a trigger.
While we can probably still refactor further to drop the command namespacing - which takes up half the entire runtime with a trigger implemented twice - this still provides a significant boost (4x as fast overall for the
user-authtrigger).Additionally, we now ignore SIGURG, which allows using a Golang newer than 1.13. See golang/go#37942 for details.
Finally, I officially switched to go-bindata/go-bindata. The source did not reflect what was previously used to wrap up the files.