-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(torii-libp2p): always use is_valid_signature #2776
Conversation
WalkthroughOhayo, sensei! This pull request introduces changes to the signature handling process in the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2776 +/- ##
==========================================
+ Coverage 56.01% 56.03% +0.01%
==========================================
Files 434 434
Lines 55068 55040 -28
==========================================
- Hits 30849 30840 -9
+ Misses 24219 24200 -19 ☔ View full report in Codecov by Sentry. |
* refactor(torii-libp2p): always use is_valid_signature * fmt
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Signature
enum, streamlining theMessage
struct to use a vector for signatures.